Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Don't review/merge yet - Attempt to fix https://github.com/angular/protractor/issues/3777 #3837

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/expectedConditions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,15 @@ export class ProtractorExpectedConditions {
* representing whether the element is visible.
*/
visibilityOf(elementFinder: ElementFinder): Function {
return this.and(this.presenceOf(elementFinder), elementFinder.isDisplayed.bind(elementFinder));
return () => {
return elementFinder.isDisplayed().then(() => true, err => {
if (err.code == webdriver.error.ErrorCode.NO_SUCH_ELEMENT) {
return false;
} else {
throw err;
}
});
};
}

/**
Expand Down