This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): remove autofocus ambiguity. #9438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The autocomplete opens the dropdown when the `md-autofocus` attribute is specified. * This wasn't docmented for a long time, since the global `md-autofocus` is a key attribute, to mark an element to be focused upon opening. (e.g `md-sidenav`, `md-bottom-sheet`, `md-dialog`. * This also fixes an issue where the autocomplete dropdown shows up twice, when having the autocomplete inside of a dialog.
ThomasBurleson
removed
the
needs: review
|
@devversion - lgtm |
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-autofocusattribute is specified.md-autofocusattribute, because it is used, to mark an element to be focused upon opening. (e.g$mdSidenav,$mdBottomSheet,$mdDialog)autocomplete inside of a dialog.
This change now provides consistency for the
md-autofocusattribute on the autocomplete as well.@ThomasBurleson This can be marked as a breaking change, but the functionality was not documented for long time.. so not sure.