This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(sidenav): observe component id change #5972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
ThomasBurleson
added
needs: work
and removed
needs: review
ThomasBurleson
added
pr: merge ready
|
@EladBezalel - please add a unit test for this. When ready, reset the label to 'needs review' plz |
ThomasBurleson
added
needs: work
and removed
pr: merge ready
EladBezalel
force-pushed
the
feat/sidenav-observe-component-id
branch
from
99744c1 to
60ed10e
Compare
EladBezalel
added
needs: review
ThomasBurleson
added
the
P4: minor
EladBezalel
force-pushed
the
feat/sidenav-observe-component-id
branch
from
60ed10e to
5bb4fff
Compare
EladBezalel
force-pushed
the
feat/sidenav-observe-component-id
branch
from
5bb4fff to
dee142a
Compare
|
@EladBezalel - this appears outdated. Please update or close. |
ThomasBurleson
added
needs: rebase
|
This issue is closed as part of our ‘Surge Focus on Material 2' efforts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidenav was registering the first interpolated component id.
Now observing the component id attribute changes, removing the old registration and registering with the new interpolated value.
fixes #4987 and #3171