Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(datepicker): add input-aria-describedby and input-aria-labelledby #12060

Merged
merged 1 commit into from
Dec 16, 2020
Merged

feat(datepicker): add input-aria-describedby and input-aria-labelledby #12060

merged 1 commit into from
Dec 16, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • There is no accessible way to associate ng-messages with an md-datepicker
  • There is no accessible way to associate a <label> in an md-input-container with a md-datepicker (also in that same input container)

Fixes #11762

What is the new behavior?

  • add input-aria-describedby and input-aria-labelledby
  • add docs and demos for new APIs
  • change String to string in datepicker param JSDoc
  • make the md-input-container example more accessible as md-input-container does not apply for="input_x" to the label when md-datepicker is used

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
feat(datepicker): add input-aria-describedby and input-aria-labelledby
218c653 
- add docs and demos for new APIs
- change String to string in datepicker param JSDoc
- make the `md-input-container` example more accessible
  as `md-input-container` does not apply `for="input_x"` to the label
  when `md-datepicker` is used

Fixes #11762
@Splaktar Splaktar added type: enhancement a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. g3: sync labels Dec 15, 2020
@Splaktar Splaktar added this to the 1.2.2 milestone Dec 15, 2020
@Splaktar Splaktar self-assigned this Dec 15, 2020
@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 15, 2020
@Splaktar Splaktar requested a review from mmalerba December 15, 2020 04:51
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Dec 15, 2020
@Splaktar Splaktar mentioned this pull request Dec 15, 2020
Closed
mmalerba
mmalerba approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Dec 16, 2020
@Splaktar Splaktar merged commit 5f8472c into master Dec 16, 2020
@Splaktar Splaktar deleted the datepicker-aria-describedby-labelledby branch December 16, 2020 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@Splaktar Splaktar

Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

feat(datePicker): add support for aria-describedby
2 participants
@Splaktar @mmalerba