Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(chips): md-max-chips support for md-contact-chips #12050

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Dec 6, 2020

PR Checklist

Please check your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • md-max-chips is not supported for md-contact-chips

Closes #10827

What is the new behavior?

  • md-max-chips is supported for md-contact-chips

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This continues the work by @kylekatarnls in PR #10827. It fixes an issue with the value of md-max-chips not being properly bound to the template of md-chips and cleans up the commit message.

@Splaktar Splaktar added this to the 1.2.2 milestone Dec 6, 2020
@Splaktar Splaktar self-assigned this Dec 6, 2020
@google-cla
Copy link

google-cla bot commented Dec 6, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Dec 6, 2020
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: enhancement and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Dec 6, 2020
@Splaktar
Copy link
Contributor Author

Splaktar commented Dec 6, 2020

@kylekatarnls Thank you for your contribution, can you please confirm your consent as requested in the previous comment?

@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Dec 6, 2020
@Splaktar Splaktar requested a review from mmalerba December 6, 2020 03:15
@Splaktar Splaktar requested review from wagnermaciel and removed request for mmalerba December 7, 2020 18:46
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Dec 9, 2020
@Splaktar Splaktar merged commit e6b5482 into master Dec 9, 2020
@Splaktar Splaktar deleted the contact-chips-max-chips branch December 9, 2020 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants