Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): time is modified before even selecting a date #12030

Merged
merged 1 commit into from
Oct 12, 2020
Merged

fix(datepicker): time is modified before even selecting a date #12030

merged 1 commit into from
Oct 12, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • time is modified before even selecting a date

Issue Number:
Fixes #12028. Closes #12026.

What is the new behavior?

  • time is not modified before selecting a date
  • updateErrorState() was mutating the model incorrectly and clearing the
    time to midnight when the datepicker is first interacted with, without
    selecting a date

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Oct 11, 2020
@Splaktar
fix(datepicker): time is modified before even selecting a date
19c7444 
- `updateErrorState()` was mutating the model incorrectly and clearing the
  time to midnight when the datepicker is first interacted with, without
  selecting a date

Fixes #12028. Closes #12026.
@Splaktar Splaktar self-assigned this Oct 11, 2020
@Splaktar Splaktar force-pushed the datepicker-initial-timezone branch from 5a31c3a to 19c7444 Compare October 11, 2020 02:34
@Splaktar Splaktar added this to the 1.2.2 milestone Oct 11, 2020
@Splaktar Splaktar added P2: required Issues that must be fixed. i18n: localization This issue is related to internationalization type: bug labels Oct 11, 2020
@Splaktar Splaktar mentioned this pull request Oct 11, 2020
Closed
@Splaktar Splaktar requested a review from wagnermaciel October 11, 2020 02:37
wagnermaciel
wagnermaciel approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Oct 12, 2020
@Splaktar Splaktar merged commit b406623 into master Oct 12, 2020
@Splaktar Splaktar deleted the datepicker-initial-timezone branch October 12, 2020 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ i18n: localization This issue is related to internationalization P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer type: bug
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

datepicker: with UTC timezone set doesn't handle time offset +2:00 datepicker: modifies time
2 participants
@Splaktar @wagnermaciel