Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(typography): enable iOS long-press context menus #12016

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(typography): enable iOS long-press context menus #12016

merged 1 commit into from
Sep 21, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • long pressing a link doesn't open the context menu on iOS

Issue Number:
Fixes #10622

What is the new behavior?

  • enable iOS long-press context menus
  • for links, this allows a range of options to be selected
  • for apps that want to disable this to pretend that they are
    native mobile apps, they can set the -webkit-touch-callout: none;
    style on their app's html, body

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
fix(typography): enable iOS long-press context menus
77e3d53 
- for links, this allows a range of options to be selected
- for apps that want to disable this to pretend that they are
  native mobile apps, they can set the `-webkit-touch-callout: none;`
  style on their app's `html, body`

Fixes #10622
@Splaktar Splaktar added type: bug ui: CSS os: iOS This issue is specific to iOS type: ionic Issues specifically related to integration with the Ionic framework. ux: integration P3: important Important issues that really should be fixed when possible. labels Sep 21, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 21, 2020
@Splaktar Splaktar self-assigned this Sep 21, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 21, 2020
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Sep 21, 2020
wagnermaciel
wagnermaciel approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 21, 2020
@Splaktar Splaktar merged commit 3d98b6e into master Sep 21, 2020
@Splaktar Splaktar deleted the ios-enable-context-menus branch September 21, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ os: iOS This issue is specific to iOS P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug type: ionic Issues specifically related to integration with the Ionic framework. ui: CSS ux: integration
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

long pressing a link doesn't open the context menu on iOS
3 participants
@Splaktar @wagnermaciel @googlebot