Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(radio-button): support selection using the space key #12014

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

We don't currently select the current radio button when the space bar is clicked. This doesn't align with the WAI-ARIA recommendations for accessibility.

Issue Number:
Fixes #11960

What is the new behavior?

  • support selection using the space key
  • add an incrementSelection enum
  • add JSDoc and improve types
  • fix typos

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- add an incrementSelection enum
- add JSDoc and improve types
- fix typos

Fixes #11960
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 18, 2020
@Splaktar Splaktar self-assigned this Sep 18, 2020
@Splaktar Splaktar added g3: reported The issue was reported by an internal or external product team. g3: sync labels Sep 18, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 18, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. type: bug labels Sep 18, 2020
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Sep 18, 2020
@Splaktar Splaktar merged commit 3cf78a7 into master Sep 18, 2020
@Splaktar Splaktar deleted the radio-button-space branch September 18, 2020 20:40
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radio-button: unable to select a radio button using space key
3 participants