Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(radio-button): Cannot read property 'nodeName' of null #12013

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Sep 13, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Some users see TypeError: Cannot read property 'nodeName' of null when on a page with a md-radio-button after they hit the browser's reload button, since AngularJS Material 1.1.1.

Issue Number:
Fixes #10546

What is the new behavior?

There is a null check before accessing the parentNode field.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

No test added as no reproduction was provided.

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 13, 2020
@Splaktar Splaktar self-assigned this Sep 13, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 13, 2020
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. severity: regression This issue is related to a regression type: bug pr: merge ready This PR is ready for a caretaker to review labels Sep 13, 2020
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 14, 2020
@Splaktar Splaktar merged commit f43ff63 into master Sep 14, 2020
@Splaktar Splaktar deleted the radio-button-exception branch September 14, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radio-button: Cannot read property 'nodeName' of null after version 1.1.1
3 participants