Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(a11y): add a list of supported screen readers #12011

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Sep 13, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Our docs say that we build "accessible UI components" but we don't specify any further details.

Issue Number:
Fixes #11449

What is the new behavior?

  • add a list of supported screen readers to docs site
  • add screen reader field to issue template
  • update browser support table
  • update README.md
    • require AngularJS 1.7.2+
    • remove out of date http://browserl.ist link and image since their site is down
    • link to screen reader support section on docs site
    • update docs site screenshot
    • add missing step to install Gulp v3 globally
    • update versions in examples to use 1.2.0

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen Shot 2020-09-13 at 01 04 08

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 13, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 13, 2020
@Splaktar Splaktar self-assigned this Sep 13, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review pr: merge safe type: docs labels Sep 13, 2020
- add screen reader field to issue template
- update browser support table
- update README.md
  - require AngularJS 1.7.2+
  - remove out of date http://browserl.ist link and image since their site is down
  - link to screen reader support section on docs site
  - update docs site screenshot
  - add missing step to install Gulp v3 globally
  - update versions in examples to use 1.2.0

Fixes #11449
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are several nits of formatting on the README that just seem to be due to your formatter, e.g. line breaks that put a word on the next line even though there is more than enough room for it on the previous line (see line 213 for example)

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 14, 2020
@Splaktar Splaktar merged commit 8ce0813 into master Sep 14, 2020
@Splaktar Splaktar deleted the docs-a11y branch September 14, 2020 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: specify the screen reader versions that are supported
3 participants