Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(calendar, datepicker): fix MomentJS custom format support #12007

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Sep 1, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • $$mdDateUtil.removeLocalTzAndReparseDate() was simplified, but it breaks MomentJS support

Issue Number:
Relates to #12003. Relates to #11949.

What is the new behavior?

  • revert simplification of $$mdDateUtil.removeLocalTzAndReparseDate()
  • enable unit testing of MomentJS
  • add test suites for MomentJS custom formatting in dateLocale.spec.js
    and datepickerDirective.spec.js

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- revert simplification of `$$mdDateUtil.removeLocalTzAndReparseDate()`
- enable unit testing of MomentJS
- add test suites for MomentJS custom formatting in `dateLocale.spec.js`
  and `datepickerDirective.spec.js`

Relates to #12003. Relates to #11949.
@Splaktar Splaktar self-assigned this Sep 1, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 1, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 1, 2020
@Splaktar Splaktar added P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug labels Sep 1, 2020
@Splaktar
Copy link
Contributor Author

Splaktar commented Sep 1, 2020

This is just a cherry pick of the same changes from the patch branch. Approved in #12006 (review).

@Splaktar Splaktar merged commit 8f9e213 into master Sep 1, 2020
@Splaktar Splaktar deleted the datepicker-fix-moment-custom-formatting-in-master branch September 1, 2020 01:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants