This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): change md-escape-options default to 'clear' #11988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously the default was `'blur clear'` - clean up tests, remove unused injections, variables, missing spaces, semi-colons Fixes #11767 BREAKING CHANGE: The default behavior of `md-autocomplete`, when the options panel is visible and the Escape key is pressed, has changed. `md-escape-options` now defaults to `'clear'` instead of `'blur clear'`. This better aligns with the [WAI-ARIA Authoring Practices](https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.0pattern/combobox-autocomplete-list.html) as the focus is not sent to another element (like the `<body>`) when the Escape key is pressed. If you want to restore the previous behavior, add the following to your `md-autocomplete` components: ```html md-escape-options="blur clear" ```
googlebot
added
the
cla: yes
Splaktar
added
a11y
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
'blur clear'<body>in Chrome after Escape is pressed while having anmd-autocompleteoptions panel open. Most screen reader users just want the panel to dismiss, they don't want their focus to be sent to the body as that may cause them to need to re-navigate the whole page again.Issue Number:
Fixes #11767
What is the new behavior?
md-escape-optionsdefaults to 'clear'Does this PR introduce a breaking change?
BREAKING CHANGE: The default behavior of
md-autocomplete, when the options panel is visible and the Escape key is pressed, has changed.md-escape-optionsnow defaults to'clear'instead of'blur clear'. This better aligns with the WAI-ARIA Authoring Practices as the focus is not sent to another element (like the<body>) when the Escape key is pressed.If you want to restore the previous behavior, add the following to your
md-autocompletecomponents:Other information