This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): md-select-header closes on mouse click when not using multiple #11970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple - if the click event came from within a `md-select-header`, `stopImmediatePropagation()` to keep the menu from closing - fix demo's input being too short to display label when 'Kale' is selected - rename some events and add types - update select header input's placeholder and add an aria-label Fixes #11969
googlebot
added
the
cla: yes
Splaktar
added
P1: urgent
Splaktar
added
pr: merge ready
|
This has been cherry picked into the |
corvinb
reviewed
Oct 11, 2020
| if (!option || !optionCtrl) { | ||
| // Avoid closing the menu when the select header's input is clicked | ||
| if (mouseEvent.target && mouseEvent.target.parentNode && | ||
| mouseEvent.target.parentNode.tagName === 'MD-SELECT-HEADER') { |
There was a problem hiding this comment.
input's are usually inside md-input-container's and this check would return false in this case. :(
There was a problem hiding this comment.
@corvinb can you please open a new issue with a reproduction?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-select-headercloses on mouse click of the header'sinputwhen not using multipleIssue Number:
Fixes #11969
What is the new behavior?
md-select-header,stopImmediatePropagation()to keep the menu from closing
Does this PR introduce a breaking change?
Other information