Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(input-container): align indentation with spec #11921

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • md-input and md-select inside of md-input-containers have excess left padding (in LTR) and right padding (in RTL)
  • labels don't match the width of their inputs when md-icon-left or md-icon-right are used

Issue Number:
Fixes #10105. Closes #11421.

What is the new behavior?

  • md-input and md-select inside of md-input-containers have indentation that matches the spec
  • labels match the width of their inputs when md-icon-left or md-icon-right are used

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@Splaktar Splaktar added - Breaking Change P3: important Important issues that really should be fixed when possible. type: spec alignment For issues related to aligning with the Material Design Spec labels May 28, 2020
@Splaktar Splaktar added this to the 1.2.0 milestone May 28, 2020
@Splaktar Splaktar self-assigned this May 28, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 28, 2020
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label May 28, 2020
@Splaktar Splaktar requested a review from mmalerba June 8, 2020 07:19
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Jun 15, 2020
Fixes #10105. Closes #11421.

BREAKING CHANGE: `md-input` and `md-select` inside of `md-input-container`s have been updated to use indentation that is consistent with the spec (aligned to the left in LTR and the right in RTL). This may cause some minor layout issues in apps that depended upon the previous `2px` padding inside of `md-input-container`.
@Splaktar Splaktar force-pushed the input-container-spec-alignment branch from 14a58a7 to 1d93f7e Compare June 29, 2020 19:49
@Splaktar
Copy link
Contributor Author

Rebased and updated commit message with breaking change note (due to layout change).

@Splaktar Splaktar merged commit 31a596f into master Jun 29, 2020
@Splaktar Splaktar deleted the input-container-spec-alignment branch June 29, 2020 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Breaking Change cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: spec alignment For issues related to aligning with the Material Design Spec ui: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input: indentation different from the Material Design spec
3 participants