This repository was archived by the owner on Sep 5, 2024. It is now read-only.
build: make the build output deterministic and reproducible #11570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
type: build
P3: important
|
Caretaker: this PR should be synced on its own. It should be a complete no-op, but on the off chance that something does break, we'll know it's from this and not another PR. |
Splaktar
force-pushed
the
gulp-deterministicBuilds
branch
from
bc4cbf9 to
944994b
Compare
Splaktar
commented
Jan 31, 2019
| .pipe(utils.cssToNgConstant('material.core', '$MD_THEME_CSS')); | ||
| var paths = config.themeBaseFiles; | ||
| config.componentPaths.forEach(component => paths.push(path.join(component, '*-theme.scss'))); | ||
| paths.push(config.themeCore); |
There was a problem hiding this comment.
This fixes the issue where some apps had a white background instead of light gray in the presubmits.
Splaktar
added
pr: presubmit-failures
and removed
pr: merge ready
|
It looks like the module builds of the CSS (closure or js) are injecting tons of extra theme template styles into component CSS like This PR tried to ignore the module based builds, but it's clear that I need to go through there and make some tweaks + verify. |
Splaktar
added
the
in progress
Splaktar
force-pushed
the
gulp-deterministicBuilds
branch
from
944994b to
08a92c0
Compare
Splaktar
added
pr: merge ready
|
Duplicate CSS in module-based builds has been resolved. This is ready for presubmit again. |
- passing globs to `gulp.src` can cause ordering to not be preserved. this is because `gulp.src` is async - gulp-concat tries to preserve the order passed into `gulp.src`. if the globbing is too vague, then there isn't enough info for ordering - more statically defining the paths like this isn't ideal but it is acceptable atm since we aren't adding new components - fix docs menu unwanted left margin - remove commented out icon styles - add JSDoc/Closure types - remove unneeded parameter passed to util.buildModule() - remove unneeded parameter passed to util.buildJs() Fixes #11502
Splaktar
force-pushed
the
gulp-deterministicBuilds
branch
from
08a92c0 to
e4bff89
Compare
Splaktar
assigned
josephperrott and
mmalerba and unassigned
andrewseguin and
josephperrott
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Consecutive builds, without any changes, result in bundle content with different ordering. This is even true in a single build where the
dist/angular-material.jsisn't identical to thedist/docs/angular-material.js. This makes comparing releases harder and it makes syncing into g3 more time consuming.gulp.srccan cause ordering to not be preserved.this is because
gulp.srcis asyncgulp.src.if the globbing is too vague, then there isn't enough info for ordering
Issue Number:
Fixes #11502
What is the new behavior?
All of the build output (JS, SCSS, CSS) should be identical if the build is run multiple times without any changes to the code.
Does this PR introduce a breaking change?
Other information
I looked at sorting the file paths manually or using
gulp-sortbut neither solution was flexible enough to order some of our internal dependencies properly. This approach seems to work fine w/o addinggulp-order, but if problems pop up in the future, that is another package that might help.Note that the root cause of this lies in the intersection of
gulp.srcin Gulp core andgulp-concat. This is a well established problem that the Gulp team has mostly decided to punt into user land or third party packages so that they can maintain speed and not need to support crazy levels of customization.