Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(chips): expose $event in md-on-remove #11192

Merged
merged 2 commits into from
Mar 29, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 26, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

It is impossible to stop propagation of the click event from md-chip-on-remove.

Issue Number:
Issue #8847
Builds on previous PR #9870 (Reviewed and approved by @devversion)

What is the new behavior?

Expose event object as parameter to onRemove function to allow for stopping propagation.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

gseabrook and others added 2 commits March 26, 2018 03:27
Expose event object as parameter to onRemove function to allow for stopping propagation

Closes #8847
@Splaktar Splaktar added type: enhancement P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer labels Mar 26, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 26, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 26, 2018
@Splaktar Splaktar changed the title Chips expose event on remove feat(chips): expose $event in md-on-remove Mar 26, 2018
@Splaktar Splaktar added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 26, 2018
@Splaktar Splaktar requested a review from devversion March 26, 2018 07:56
@josephperrott josephperrott merged commit bd3aa1d into master Mar 29, 2018
@Splaktar Splaktar deleted the chipsExposeEventOnRemove branch March 30, 2018 01:46
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants