This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): remove 2px left padding on inputs #11421
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove 2px of padding-left from input boxes as this does not follow the material design spec
Fixes #10105
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently input boxes have 2px of padding-left. The material design spec has no left padding.
According to the original material design spec only top and bottom padding should exist on input fields.
Issue Number: #10105
What is the new behavior?
The 2px of left padding have been removed.
Does this PR introduce a breaking change?
This will change the styling of input components, although a minor change, anyone who has styled specifically around this may need to make minor changes to their own styles.
Other information
It does not seem that autocomplete or datepicker have this extra padding and they don't seem to be using the modified class. It seems that the only affected component will be input and all the other components are following the spec.