This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat: add cookie popup #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
cookie-popup
branch
3 times, most recently
from
23e18b2 to
bb35d79
Compare
RitikDua
reviewed
May 22, 2021
|
@jelbourn I've reworked it based on our discussion. |
jelbourn
reviewed
May 25, 2021
tools/audit-docs.js
Outdated
| 'accessibility': 100 | ||
| // We lose a few points on accessibility, because there isn't quite enough contrast on the | ||
| // buttons in the cookie popup. This is a known issue with the Material Design theming system. | ||
| 'accessibility': 98 |
There was a problem hiding this comment.
Can we tweak the colors to avoid dinging this?
There was a problem hiding this comment.
Done. It looks like I only had to darken the original color by 5%.
Due to legal requirements we have to have a cookie disclaimer popup. It is always shown until the user agrees to it. After the user has agreed, the popup won't be shown on subsequent sessions. Fixes angular/components#22746.
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jun 12, 2021
This commit adds a popup to angular.io to inform the user about the use of cookies. Once the user confirms having read the info, the popup will not be shown on subsequent visits. This commit is partly based on angular/material.angular.io#988. Fixes angular#42209
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jun 14, 2021
…42259) This commit adds a popup to angular.io to inform the user about the use of cookies. Once the user confirms having read the info, the popup will not be shown on subsequent visits. This commit is partly based on angular/material.angular.io#988. Fixes #42209 PR Close #42259
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Jun 14, 2021
…42259) This commit adds a popup to angular.io to inform the user about the use of cookies. Once the user confirms having read the info, the popup will not be shown on subsequent visits. This commit is partly based on angular/material.angular.io#988. Fixes #42209 PR Close #42259
|
Any chance that we could get this added to the library as a component users of Angular Material could use? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to legal requirements we have to have a cookie disclaimer popup. It is always shown until the user agrees to it. After the user has agreed, the popup won't be shown on subsequent sessions.
Fixes angular/components#22746.
Note: currently this doesn't have any accessibility treatment, because I'm not sure what the correct approach would be. I assume that we'd have to move focus into the cookie popup since it has more than one button, but its
roleis currently eitherstatusoralertwhich may not make sense to receive focus and to contain buttons.