refactor(option): move styles out of mat-core and into styleUrls #9115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
option-styling-location
branch
3 times, most recently
from
904a77a to
99c8dbc
Compare
Moves the styling for `MatOption` and `MatOptgroup` out of the `mat-core` mixin and into their components' respective `styleUrls`. This avoids the styles potentially being included multiple times if `mat-core` is used in different places and is consistent with all other components.
crisbeto
force-pushed
the
option-styling-location
branch
from
99c8dbc to
ab26792
Compare
crisbeto
commented
Dec 24, 2017
| @@ -7,7 +7,7 @@ ng_module( | |||
| name = "core", | |||
| srcs = glob(["**/*.ts"], exclude=["**/*.spec.ts"]), | |||
| module_name = "@angular/material/core", | |||
| assets = [":pseudo_checkbox_css"], | |||
| assets = [":pseudo_checkbox_css", ":option_css", ":optgroup_css"], | |||
There was a problem hiding this comment.
@jelbourn these changes seem to make Bazel happy, but I'm not sure whether it's the proper way to do it.
jelbourn
approved these changes
Jan 12, 2018
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…ular#9115) Moves the styling for `MatOption` and `MatOptgroup` out of the `mat-core` mixin and into their components' respective `styleUrls`. This avoids the styles potentially being included multiple times if `mat-core` is used in different places and is consistent with all other components.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the styling for
MatOptionandMatOptgroupout of themat-coremixin and into their components' respectivestyleUrls. This avoids the styles potentially being included multiple times ifmat-coreis used in different places and is consistent with all other components.