Skip to content

fix(progress-circle): remove references to window #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

crisbeto
Copy link
Member

  • Removes the references to window in the progressCircle component.
  • A couple of minor coding style tweaks.

Fixes #837.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 10, 2016
@@ -124,13 +124,13 @@ export class MdProgressCircle implements OnDestroy {
get mode() {
return this._mode;
}
set mode(m: ProgressCircleMode) {
if (m == 'indeterminate') {
set mode(_mode: ProgressCircleMode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underscore is used for private/internal class members. Function arguments should not use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will revert.

* Removes the references to `window` in the progressCircle component.
* A couple of minor coding style tweaks.

Fixes angular#837.
@crisbeto crisbeto force-pushed the fix/progress-circle-global branch from e843bc2 to a8c59d4 Compare July 11, 2016 17:37
@jelbourn
Copy link
Member

LGTM

@crisbeto
Copy link
Member Author

The CI seems to be failing because of some unrelated Node error.

@jelbourn jelbourn merged commit 66ddd3a into angular:master Jul 13, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: window is not defined at now in progress-circle.js
3 participants