fix(progress-circle): remove references to window #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -124,13 +124,13 @@ export class MdProgressCircle implements OnDestroy { | |||
| get mode() { | |||
| return this._mode; | |||
| } | |||
| set mode(m: ProgressCircleMode) { | |||
| if (m == 'indeterminate') { | |||
| set mode(_mode: ProgressCircleMode) { | |||
There was a problem hiding this comment.
The underscore is used for private/internal class members. Function arguments should not use it.
* Removes the references to `window` in the progressCircle component. * A couple of minor coding style tweaks. Fixes angular#837.
crisbeto
force-pushed
the
fix/progress-circle-global
branch
from
e843bc2 to
a8c59d4
Compare
|
LGTM |
|
The CI seems to be failing because of some unrelated Node error. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowin the progressCircle component.Fixes #837.