-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: remove all @internal to fix offline compile #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did you just remove all of them or did you actrually only removed the ones that were harmful? |
To elaborate, with this PR, anything that is not part of the public API is prefixed with an underscore. Some of those things may be actual |
@hansl All of them, because there were very, very few that were actually not a problem (just a few in grid-list). I'm saying it's better to completely forgo using |
Also, anything marked with |
04814a7
to
db5b673
Compare
@@ -81,7 +81,7 @@ export class MdButtonToggleGroup implements ControlValueAccessor { | |||
|
|||
/** Child button toggle buttons. */ | |||
@ContentChildren(forwardRef(() => MdButtonToggle)) | |||
private _buttonToggles: QueryList<MdButtonToggle> = null; | |||
_buttonToggles: QueryList<MdButtonToggle> = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this one changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ContentChildren
etc. also can't be private, since Angular itself needs to touch them
06abe7d
to
68f2971
Compare
LGTM as well. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @robertmesserle @hansl @kara
CC: @iveysaur @devversion
When the code generated by the angular compiler interacts with the component, it does so through its class's public API. If anything is missing from the
.d.ts
, it will be an error when a downstream application tries to compile.Also fixes some errors with tab's use of
ngIf