Skip to content

chore: remove all @internal to fix offline compile #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

jelbourn
Copy link
Member

R: @robertmesserle @hansl @kara
CC: @iveysaur @devversion

When the code generated by the angular compiler interacts with the component, it does so through its class's public API. If anything is missing from the .d.ts, it will be an error when a downstream application tries to compile.

Also fixes some errors with tab's use of ngIf

@hansl
Copy link
Contributor

hansl commented Jun 29, 2016

Did you just remove all of them or did you actrually only removed the ones that were harmful?

@jelbourn
Copy link
Member Author

To elaborate, with this PR, anything that is not part of the public API is prefixed with an underscore. Some of those things may be actual private, and other are TypeScript "public" so that Angular itself can see them, but are not intended to be exposed to end developers.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 29, 2016
@jelbourn
Copy link
Member Author

@hansl All of them, because there were very, very few that were actually not a problem (just a few in grid-list). I'm saying it's better to completely forgo using @internal because it's too easy to introduce an error with it.

@jelbourn
Copy link
Member Author

Also, anything marked with TODO: internal is something for us to eventually mark as "Looks public, but needs to be omitted from the API docs", such as ControlValueAccessor methods and lifecycle hooks.

@jelbourn jelbourn force-pushed the correct-access-levels branch from 04814a7 to db5b673 Compare June 29, 2016 01:24
@@ -81,7 +81,7 @@ export class MdButtonToggleGroup implements ControlValueAccessor {

/** Child button toggle buttons. */
@ContentChildren(forwardRef(() => MdButtonToggle))
private _buttonToggles: QueryList<MdButtonToggle> = null;
_buttonToggles: QueryList<MdButtonToggle> = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this one changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ContentChildren etc. also can't be private, since Angular itself needs to touch them

@jelbourn jelbourn force-pushed the correct-access-levels branch from 06abe7d to 68f2971 Compare July 7, 2016 00:36
@hansl
Copy link
Contributor

hansl commented Jul 7, 2016

LGTM as well.

@jelbourn jelbourn merged commit fad4ef5 into angular:master Jul 7, 2016
@jelbourn jelbourn deleted the correct-access-levels branch September 13, 2017 04:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants