feat(autocomplete): add isOpen attribute #7149
Conversation
googlebot
added
the
cla: yes
src/lib/autocomplete/autocomplete.ts
Outdated
| @@ -57,6 +57,11 @@ export class MdAutocomplete implements AfterContentInit { | |||
| /** Whether the autocomplete panel should be visible, depending on option length. */ | |||
| showPanel = false; | |||
|
|
|||
| _isOpen: boolean = false; | |||
There was a problem hiding this comment.
I'm not sure we need this extra flag. isOpen should be the same as this.showPanel && this.options.length > 0.
There was a problem hiding this comment.
That was my initial thought as well, however, showPanel is not set to false on blur, which prevents it from working that way.
There was a problem hiding this comment.
Cool, also a final nit: can you add a doc string to the isOpen getter so it shows up in the docs?
There was a problem hiding this comment.
Yeah, not sure how I deleted the doc line I had for it.
| @@ -66,19 +66,6 @@ | |||
| </md-card> | |||
| </div> | |||
|
|
|||
| <md-autocomplete #reactiveAuto="mdAutocomplete" [displayWith]="displayFn"> | |||
There was a problem hiding this comment.
Why were these removed from the demo?
There was a problem hiding this comment.
They are duplicates of the same elements above.
It look slike we had 5 <md-autocomplete>s for 3 [mdAutocompleteTrigger]s
src/lib/autocomplete/autocomplete.ts
Outdated
| @@ -57,6 +57,11 @@ export class MdAutocomplete implements AfterContentInit { | |||
| /** Whether the autocomplete panel should be visible, depending on option length. */ | |||
| showPanel = false; | |||
|
|
|||
| _isOpen: boolean = false; | |||
josephperrott
force-pushed
the
autocomplete-is-open
branch
from
af86974 to
a674455
Compare
crisbeto
added
pr: lgtm
action: merge
- Add isOpen attribute to `MdAutocomplete` component.
josephperrott
force-pushed
the
autocomplete-is-open
branch
from
a674455 to
4ed1c13
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
For #5881