Skip to content

fix: Remove MaterialModule #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Sep 1, 2017

BREAKING CHANGE: MaterialModule will no longer be available.

MaterialModulehas been deprecated since beta.3 and is now being removed.

From beta.3 changelog:

MaterialModule

  • MaterialModule (and MaterialRootModule) have been marked as deprecated.

We've found that, with the current state of tree-shaking in the world,
that using an aggregate NgModule like MaterialModule leads to tools
not being able to eliminate code for components that aren't used.

In order to ensure that users end up with the smallest code size
possible, we're deprecating MaterialModule, to be removed in the a
subsequent release.

To replace MaterialModule, users can create their own "Material"
module within their application (e.g., GmailMaterialModule) that
imports only the set of components actually used in the application.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- can you amend your commit to have a BREAKING CHANGES marker?

@josephperrott josephperrott force-pushed the materialmodule branch 2 times, most recently from ac0176d to a345de1 Compare September 1, 2017 23:03
BREAKING CHANGE: MaterialModule has been removed and is no longer available.  As noted in the changelog for beta.3, an aggregate module like MaterialModule prevents tools from being able to treeshake unused components and modules.
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 1, 2017
@tinayuangao tinayuangao merged commit cf1ece0 into angular:master Sep 6, 2017
@josephperrott josephperrott deleted the materialmodule branch September 7, 2017 22:15
@ghost
Copy link

ghost commented Sep 27, 2017

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11",

@WindMay
Copy link

WindMay commented Sep 29, 2017

@George35mk

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11"

Build a like the one that was deleted, but remove the modules that you don't use

cf1ece0

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants