refactor: initialize to empty subscriptions #6769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
willshowell
reviewed
Aug 31, 2017
| if (this._resizeSubscription) { | ||
| this._resizeSubscription.unsubscribe(); | ||
| } | ||
| this._resizeSubscription.unsubscribe(); |
There was a problem hiding this comment.
It looks like this one isn't even needed if you change the method to
ngOnDestroy() {
this._onDestroy.next();
this._onDestroy.complete();
}
Initializes most subscriptions to empty ones, avoiding the need to null-check them before unsubscribing.
crisbeto
force-pushed
the
empty-subscription-init
branch
from
824e7b9 to
b524887
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes most subscriptions to empty ones, avoiding the need to null-check them before unsubscribing.
Note: There are a few more candidates for refactor (namely the table and the scroll strategies), but in those cases we use the subscriptions to manage state.