Skip to content

a11y(radio): Add radio buttons accessibility demo page #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2017
Merged

a11y(radio): Add radio buttons accessibility demo page #5958

merged 3 commits into from
Jul 28, 2017

Conversation

tinayuangao
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 22, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 27, 2017
@tinayuangao tinayuangao added pr: needs review and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 27, 2017
@tinayuangao tinayuangao added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2017
jelbourn
jelbourn reviewed Jul 27, 2017
View reviewed changes
src/demo-app/a11y/radio/radio-a11y.html Outdated
@@ -0,0 +1,32 @@
<section>
<h2>Radio buttons in group</h2>
<md-radio-group name="seasons" [(ngModel)]="favoriteSeason">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each radio-group should have an aria-label (e.g. "Seasons") or an aria-labelledby (example)

src/demo-app/a11y/radio/radio-a11y.html Outdated
<md-radio-group name="my_options" align="end">
<md-radio-button value="option_1">Option 1</md-radio-button>
<md-radio-button value="option_2">Option 2</md-radio-button>
<md-radio-button value="option_3">Option 3</md-radio-button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to use more meaningful options (like the seasons example does). Good examples could be pizza toppings, ice cream flavors, varieties of tea, types of bread, etc.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 27, 2017
jelbourn
jelbourn approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add the merge-ready label when ready

src/demo-app/a11y/radio/radio-a11y.html
</section>

<section>
<h2>Disabled radio buttons</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a <p> under the header like

<p>This section contains three radio buttons for "Yes", "No", and "Maybe". The "Maybe" radio button is disabled.</p>

@jelbourn jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement pr: lgtm and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla pr: needs review labels Jul 27, 2017
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 27, 2017
@tinayuangao tinayuangao added action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 27, 2017
@jelbourn jelbourn added the Accessibility This issue is related to accessibility (a11y) label Jul 27, 2017
@andrewseguin andrewseguin merged commit 53e3fd9 into angular:master Jul 28, 2017
@tinayuangao tinayuangao deleted the a11y-radio branch March 9, 2018 23:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tinayuangao @googlebot @jelbourn @andrewseguin @devversion