internal: enforce component owners in pullapprove yml #5366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Jun 26, 2017
.pullapprove.yml
Outdated
| ripple: | ||
| conditions: | ||
| files: | ||
| - 'src/(demo-app|e2e-app|lib)/ripple/*' |
There was a problem hiding this comment.
Should this be /core/ripple/*?
.pullapprove.yml
Outdated
| conditions: | ||
| files: | ||
| - 'src/(demo-app|e2e-app|lib)/slide-toggle/*' | ||
| - 'src/material-examples/slide-toggle-*' |
There was a problem hiding this comment.
This seems to be slide-toggle while it should be typography?
jelbourn
reviewed
Jun 26, 2017
|
done |
jelbourn
added
pr: lgtm
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* internal: enforce component owners in pullapprove yml * fix some copy-paste mistakes * add crisbeto to overlay owners
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added @jelbourn as backup on all components, @mmalerba as backup on components owned by @jelbourn