feat(data-table): add row context #5219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -42,4 +43,8 @@ export class DataTableDemo { | |||
| this.propertiesToDisplay.splice(colorColumnIndex, 1); | |||
| } | |||
| } | |||
|
|
|||
| toggleHighlight(property: string, enable: any) { | |||
| enableRowContextClasses = false; | ||
| enableCellContextClasses = false; | ||
|
|
||
| @ViewChild(CdkTable) table: CdkTable<TestData>; |
There was a problem hiding this comment.
I'm totally blanking on why ViewChild is needed for this example. Can you remind me?
There was a problem hiding this comment.
Whoops, either a copy-paste problem or eventually didn't need the table in the tests. Thanks!
jelbourn
reviewed
Jun 19, 2017
| // rows to be added, removed, or moved. The view container contains the same context | ||
| // that was provided to each of its cells. | ||
| for (let index = 0, count = viewContainer.length; index < count; index++) { | ||
| const viewRef = <EmbeddedViewRef<CdkCellOutletRowContext<T>>> viewContainer.get(index); |
src/lib/core/data-table/row.ts
Outdated
| get even(): boolean { return this.index % 2 === 0; } | ||
|
|
||
| /** True if this cell is contained in a row with an odd-numbered index. */ | ||
| get odd(): boolean { return !this.even; } |
There was a problem hiding this comment.
These should be set statically; getters and setters generate a lot of code, so it's better to avoid them when they're not necessary
|
Made changes, thanks for the review |
jelbourn
reviewed
Jun 21, 2017
src/lib/core/data-table/row.ts
Outdated
| @@ -89,6 +89,29 @@ export class CdkRowDef extends BaseRowDef { | |||
| } | |||
| } | |||
|
|
|||
| /** Context provided to the row cells */ | |||
| export class CdkCellOutletRowContext<T> { | |||
ErinCoughlan
approved these changes
Jun 21, 2017
src/lib/core/data-table/row.ts
Outdated
| @@ -89,6 +89,29 @@ export class CdkRowDef extends BaseRowDef { | |||
| } | |||
| } | |||
|
|
|||
| /** Context provided to the row cells */ | |||
| export class CdkCellOutletRowContext<T> { | |||
andrewseguin
force-pushed
the
table-more-context
branch
from
d8e75ac to
d359ca1
Compare
|
Converted to an interface |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds index, count, first, last, even, odd to the row context for rows and cells