Skip to content

build: missing import in payload script #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2017
Merged

build: missing import in payload script #5058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tools/gulp/tasks/payload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import {statSync} from 'fs';
import {isTravisBuild, isTravisMasterBuild} from '../util/travis-ci';
import {buildConfig} from '../packaging/build-config';
import {openFirebaseDashboardApp, openFirebaseDashboardAppAsGuest} from '../util/firebase';
import * as firebaseAdmin from 'firebase-admin';


// These imports lack of type definitions.
const request = require('request');
Expand Down Expand Up @@ -66,7 +68,8 @@ function getFilesize(filePath: string) {
* Calculates the difference between the last and current library payload.
* The results will be published as a commit status on Github.
*/
async function calculatePayloadDiff(database: any, currentSha: string, currentPayload: any) {
async function calculatePayloadDiff(database: firebaseAdmin.database.Database, currentSha: string,
currentPayload: any) {
const authToken = process.env['FIREBASE_ACCESS_TOKEN'];

if (!authToken) {
Expand Down Expand Up @@ -121,14 +124,15 @@ async function updateGithubStatus(commitSha: string, payloadDiff: number, authTo
}

/** Uploads the current payload results to the Dashboard database. */
async function uploadPayloadResults(database: any, currentSha: string, currentPayload: any) {
async function uploadPayloadResults(database: firebaseAdmin.database.Database, currentSha: string,
currentPayload: any) {
if (isTravisMasterBuild()) {
await database.ref('payloads').child(currentSha).set(currentPayload);
}
}

/** Gets the last payload uploaded from previous Travis builds. */
async function getLastPayloadResults(database: admin.database.Database) {
async function getLastPayloadResults(database: firebaseAdmin.database.Database) {
const snapshot = await database.ref('payloads')
.orderByChild('timestamp')
.limitToLast(1)
Expand Down
4 changes: 2 additions & 2 deletions tools/gulp/tasks/screenshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {task} from 'gulp';
import {readdirSync, statSync, existsSync, mkdirp, readFileSync, writeFileSync} from 'fs-extra';
import * as path from 'path';
import * as admin from 'firebase-admin';
import * as firebaseAdmin from 'firebase-admin';
import * as firebase from 'firebase';
import {
openScreenshotsBucket,
Expand Down Expand Up @@ -55,7 +55,7 @@ function updateResult(database: firebase.database.Database, prNumber: string, re
.child(process.env['TRAVIS_PULL_REQUEST_SHA']).set(result).then(() => result);
}

function getPullRequestRef(database: firebase.database.Database | admin.database.Database,
function getPullRequestRef(database: firebase.database.Database | firebaseAdmin.database.Database,
prNumber: string) {
let secureToken = getSecureToken();
return database.ref(FIREBASE_REPORT).child(prNumber).child(secureToken);
Expand Down