feat(input): autosize sets default amount of rows to one #4906
Conversation
googlebot
added
the
cla: yes
src/lib/input/autosize.ts
Outdated
| * Browsers by default set the rows property to two. Therefore setting the minRows and maxRows | ||
| * binding to something below two doesn't work. | ||
| */ | ||
| private _setInitialRows() { |
There was a problem hiding this comment.
Is there any reason this can't be a simple host binding of {'rows': '1')?
There was a problem hiding this comment.
Not at all. I totally forgot about this 😄
There was a problem hiding this comment.
Done. Not sure why the screenshot tests fail. The images don't seem to be different.
devversion
force-pushed
the
feat/autosize-one-row
branch
from
f2ba6b2 to
fad1aa2
Compare
mmalerba
added
pr: lgtm
action: merge
src/lib/input/autosize.ts
Outdated
| @@ -10,6 +10,9 @@ import {Directive, ElementRef, Input, AfterViewInit} from '@angular/core'; | |||
| exportAs: 'mdTextareaAutosize', | |||
| host: { | |||
| '(input)': 'resizeToFitContent()', | |||
| // Textarea elements that have the directive applied should have a single row by default. | |||
| // Browsers normally show two rows by default and this makes the minRows and maxRows unusable. | |||
There was a problem hiding this comment.
Maybe a bit overstated: without this it's just a problem for minRows=1
There was a problem hiding this comment.
In theory it could be also for maxRows because if someone sets maxRows=1 it would be still at two rows I think.
But yeah, who would set maxRows=1 if he wants autosize.
* The autosize directive now sets the rows property of the textarea to one by default. * This is necessary because browsers by default set the rows property to two and therefore setting the minRows and maxRows binding to something below two doesn't work. Fixes angular#4852
devversion
force-pushed
the
feat/autosize-one-row
branch
from
a74a1cf to
89b378e
Compare
|
@jelbourn Updated the comment. Let me know if I should change anything else. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: The test looks more complex than you'd expect. I wanted to have the test also confirm that the textarea can still grow (even if rows is set to
1always)Fixes #4852