Skip to content

feat(menu): coercing overlapTrigger attribute #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat(menu): coercing overlapTrigger attribute #4882

wants to merge 3 commits into from

Conversation

ocarreterom
Copy link
Contributor

Uses coerceBooleanProperty for overlapTrigger attribute.

<md-menu overlapTrigger="false"></md-menu>

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 30, 2017
@ocarreterom
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 30, 2017
@ocarreterom ocarreterom changed the title feat(md-menu): coercing overlapTrigger attribute feat(menu): coercing overlapTrigger attribute May 31, 2017
@Input() overlapTrigger = true;
@Input()
get overlapTrigger(): boolean { return this._overlapTrigger; }
set overlapTrigger(value: boolean) { this._overlapTrigger = coerceBooleanProperty(value); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coerceBooleanProperty should only be used for things that start as false and are optionally turned to true.

@kara was overlapTrigger meant to be set to true by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should overlap the trigger by default

@jelbourn
Copy link
Member

This will be captured in #7283

@jelbourn jelbourn closed this Sep 26, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants