-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(menu): coercing overlapTrigger attribute #4882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@Input() overlapTrigger = true; | ||
@Input() | ||
get overlapTrigger(): boolean { return this._overlapTrigger; } | ||
set overlapTrigger(value: boolean) { this._overlapTrigger = coerceBooleanProperty(value); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coerceBooleanProperty
should only be used for things that start as false
and are optionally turned to true
.
@kara was overlapTrigger
meant to be set to true
by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should overlap the trigger by default
This will be captured in #7283 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uses coerceBooleanProperty for
overlapTrigger
attribute.