Skip to content

update(slide-toggle): add focus indicator #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented May 19, 2016

The temporary ripple follows the specs, and uses the palette on checked state, and black on unchecked state.

Fixes #471.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2016

&.md-primary {
@include md-switch-checked($md-primary);
@include md-switch-ripple($md-primary);
Copy link
Member Author

@devversion devversion May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I know, this could be grouped up, into one mixin. But since this is quite temporary and more clear, I decided to do it this way.

@devversion devversion force-pushed the update/slide-toggle-focus-indicator branch from 6fa546e to 5a57133 Compare May 19, 2016 20:17
@jelbourn
Copy link
Member

LGTM, just needs rebase now

@devversion devversion force-pushed the update/slide-toggle-focus-indicator branch from 5a57133 to 19f9974 Compare May 23, 2016 19:47
@devversion
Copy link
Member Author

devversion commented May 23, 2016

Done @jelbourn :)

@jelbourn jelbourn merged commit dc45b79 into angular:master May 23, 2016
@devversion devversion deleted the update/slide-toggle-focus-indicator branch May 23, 2016 20:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-slide-toggle: has no focus indicator
3 participants