Skip to content

chore: prevent ripple geometry test from running when iOS simulator fails to constrain window size #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented May 12, 2017

No description provided.

@jelbourn jelbourn added the in progress This issue is currently in progress label May 12, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2017
@jelbourn jelbourn changed the title wip debug ci chore: prevent geometry test from running when iOS simulator fails to constrain window size May 12, 2017
@jelbourn jelbourn added pr: needs review and removed in progress This issue is currently in progress labels May 12, 2017
@jelbourn jelbourn changed the title chore: prevent geometry test from running when iOS simulator fails to constrain window size chore: prevent ripple geometry test from running when iOS simulator fails to constrain window size May 12, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment May 12, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 12, 2017
@kara kara merged commit 37591fa into angular:master May 12, 2017
@jelbourn jelbourn deleted the ci-fix branch September 13, 2017 04:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants