Skip to content

docs(getting-started): mention import order for BrowserModule #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2017
Merged

docs(getting-started): mention import order for BrowserModule #4291

merged 1 commit into from
Apr 26, 2017

Conversation

jelbourn
Copy link
Member

Fixes #4278

@jelbourn jelbourn requested a review from mmalerba April 26, 2017 18:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 26, 2017
@jelbourn jelbourn mentioned this pull request Apr 26, 2017
Closed
mmalerba
mmalerba reviewed Apr 26, 2017
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still planning to change BrowserModule so this won't be necessary?

@jelbourn
Copy link
Member Author

@mmalerba I tried, there's not actually anything that can be done

@jelbourn jelbourn force-pushed the browser-module-import-mention branch from 144d23c to 5ef2e8e Compare April 26, 2017 20:27
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 26, 2017
@mmalerba mmalerba merged commit 5586864 into angular:master Apr 26, 2017
@jelbourn jelbourn deleted the browser-module-import-mention branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't drag md-slider
3 participants
@jelbourn @mmalerba @googlebot