-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: add tslint formatting task #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't really think that it is necessary to have such a task. It happens to rarely that we add/remove tslint rules. Most of the time those rules can be fixed manually very quickly and if really necessary we can just run |
I think it's fine, because:
|
Hm I personally not agree with that.
Decision might be up to @jelbourn. I just want to make sure that we don't add stuff to the build process that will be likely used once in a year. It should be as tight & clean as possible. |
FWIW, it's not only down to |
@crisbeto The |
My guess is that will be the case once we disable the custom rule for unused imports, which throws an error atm, and we start using tslint's built-in rule. |
Yeah but that is a separate issue to fix the |
I'm all for auto-fix, and we should probably just make it a pre-commit hook for everyone (probably without @crisbeto what is the set of things it will fix? Presumably obvious things like missing semi-colon and using the wrong quotes, but I'd guess line-breaking would be out of scope. |
I believe that it depends on whether the particular rule has a corresponding "fixer". Not sure if there's a good way to see which ones do, though. These are the built-in ones that do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto just needs rebase |
Adds a Gulp task that fixes TSLint errors automatically when possible. This should make it easier to add/remove linting rules.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a Gulp task that fixes TSLint errors automatically when possible. This should make it easier to add/remove linting rules.