fix(material/slide-toggle): increase slide toggle touch target #31178
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
adolgachev and
andrewseguin
and removed request for
a team
essjay05
force-pushed
the
slide-toggle-increase-touch-target
branch
2 times, most recently
from
42a8d10 to
240e097
Compare
essjay05
added
the
dev-app preview
|
Deployed dev-app for 4416dec to: https://ng-dev-previews-comp--pr-angular-components-31178-dev-ytqsnhym.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
slide-toggle-increase-touch-target
branch
from
240e097 to
605e2a7
Compare
essjay05
force-pushed
the
slide-toggle-increase-touch-target
branch
from
605e2a7 to
bbc90d1
Compare
wagnermaciel
approved these changes
Jun 2, 2025
adolgachev
approved these changes
Jun 2, 2025
essjay05
force-pushed
the
slide-toggle-increase-touch-target
branch
from
bbc90d1 to
58ea746
Compare
Updates Angular Components Slide Toggle component and increases the touch target to meet strict accessibility guidelines of buttons having a minimum touch target of 48x48 pixels. Fixes b/265033905
Updates previous changes to remove empty whitespaces causing lint errors.
essjay05
force-pushed
the
slide-toggle-increase-touch-target
branch
from
58ea746 to
4416dec
Compare
adolgachev
added
action: global presubmit
| @@ -21,6 +21,27 @@ $fallbacks: m3-slide-toggle.get-tokens(); | |||
| padding: 0; | |||
| position: relative; | |||
|
|
|||
| &::after { | |||
There was a problem hiding this comment.
My understanding is that the slide toggle's touch target is determined by the token slide-toggle-state-layer-size. If we just increase it to 48px for density: 0, doesn't that resolve this in the same way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Slide Toggle component and increases
the touch target to meet strict accessibility guidelines of buttons having
a minimum touch target of 48x48 pixels.
Before screenshot
Before screencast
After screenshot
After screencast
Fixes b/265033905