Skip to content

docs: switch remaining docs to @use #22527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

crisbeto
Copy link
Member

Updates all of the remaining docs to go through the new @use API instead of @import.

Note: does not include the mdc-button readme, because the necessary mixins aren't exported yet. See #22449.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: rc This PR is targeted for the next release-candidate labels Apr 21, 2021
@crisbeto crisbeto requested review from jelbourn and mmalerba April 21, 2021 16:30
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 21, 2021
@crisbeto crisbeto added docs This issue is related to documentation and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 21, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 21, 2021
@google-cla

This comment has been minimized.

@@ -7,7 +7,7 @@ using the CDK on its own, you'll have to include the styles yourself. You can do
the prebuilt styles in your global stylesheet:

```scss
@import '~@angular/cdk/overlay-prebuilt.css';
@use '~@angular/cdk/overlay-prebuilt.css';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was actually a native CSS @import rather than a Sass import (because of the .css extension).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted, although I think that the result will be the same for Webpack projects where @import statements inline their result.

Updates all of the remaining docs to go through the new `@use` API instead of `@import`.

**Note:** does not include the `mdc-button` readme, because the necessary mixins aren't exported yet. See angular#22449.
@crisbeto crisbeto force-pushed the use-docs-migration branch from d0bcd1a to 39979b7 Compare April 22, 2021 05:33
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2021
@andrewseguin andrewseguin merged commit 1def768 into angular:master Apr 27, 2021
andrewseguin pushed a commit that referenced this pull request Apr 27, 2021
Updates all of the remaining docs to go through the new `@use` API instead of `@import`.

**Note:** does not include the `mdc-button` readme, because the necessary mixins aren't exported yet. See #22449.

(cherry picked from commit 1def768)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants