Skip to content

build: add peer dependency to rxjs #22471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

build: add peer dependency to rxjs #22471

merged 1 commit into from
Apr 13, 2021

Conversation

crisbeto
Copy link
Member

Adds a peer dependency to rxjs to all packages since not having it can mess with Yarn 2's PnP feature.

@crisbeto
build: add peer dependency to rxjs
7c500d4 
Adds a peer dependency to `rxjs` to all packages since not having it can mess with Yarn 2's PnP feature.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Apr 13, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Apr 13, 2021
@crisbeto crisbeto requested review from jelbourn and devversion April 13, 2021 15:38
@crisbeto crisbeto requested a review from a team as a code owner April 13, 2021 15:38
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 13, 2021
jelbourn
jelbourn approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 13, 2021
@mmalerba mmalerba merged commit 6626fee into angular:master Apr 13, 2021
@crisbeto crisbeto mentioned this pull request Apr 13, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @mmalerba