Skip to content

fix(material/core): expose mixin mentioned in the elevation guide #22426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 7, 2021

We were mentioning the mat-elevation-transition mixin, but the new API wasn't exposing it. Also updates the imports to the new API.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Apr 7, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Apr 7, 2021
@crisbeto crisbeto requested a review from jelbourn April 7, 2021 19:22
@crisbeto crisbeto requested a review from devversion as a code owner April 7, 2021 19:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 7, 2021
@crisbeto crisbeto force-pushed the elevation-transition-mixin branch from 2982644 to 3641e64 Compare April 7, 2021 19:27
@crisbeto crisbeto removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 7, 2021
@crisbeto crisbeto force-pushed the elevation-transition-mixin branch from 3641e64 to a6991e9 Compare April 7, 2021 19:34
We were mentioning the `mat-elevation-transition` mixin, but the new API wasn't exposing it. Also updates the imports to the new API.
@crisbeto crisbeto force-pushed the elevation-transition-mixin branch from a6991e9 to a5e6977 Compare April 8, 2021 06:48
@crisbeto
Copy link
Member Author

crisbeto commented Apr 8, 2021

Caretaker note: based on the discussion above, I've renamed the mat-elevation-transition-property-value function to mat-private-elevation-transition-property-value. The 4 usages inside g3 should either be switched to the hardcoded value from inside the function, or temporarily moved over to use the private function until they can be migrated.

@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 8, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 8, 2021
@mmalerba mmalerba merged commit dd1d28f into angular:master Apr 13, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants