Skip to content

fix(material/sort): fix undefined object access #22355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

swftvsn
Copy link
Contributor

@swftvsn swftvsn commented Mar 27, 2021

This commit fixes hard crash that results from accessing undefined object's property.

This commit fixes hard crash that results from accessing undefined object's property.
@swftvsn swftvsn requested a review from andrewseguin as a code owner March 27, 2021 08:11
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but you have to run yarn approve-api sort and commit the changed file.

@swftvsn
Copy link
Contributor Author

swftvsn commented Apr 7, 2021

The code looks good, but you have to run yarn approve-api sort and commit the changed file.

Unfortunately I'm doing the edits from the GitHub web-interface, so it'll be some weeks (considering my workload atm) before I'm able to setup the whole dev environment for components.

@chunghha
Copy link
Contributor

Instead of waiting, can we get this PR merged for a release as this is a production bug to who use current v11 version in their production?

@aailyin
Copy link

aailyin commented Apr 27, 2021

Instead of waiting, can we get this PR merged for a release as this is a production bug to who use current v11 version in their production?

The same problem.
@swftvsn When are going to release this fix?

@swftvsn
Copy link
Contributor Author

swftvsn commented May 6, 2021

Instead of waiting, can we get this PR merged for a release as this is a production bug to who use current v11 version in their production?

The same problem.
@swftvsn When are going to release this fix?

I have no relation to angular and unfortunately I'm drowning in work. My superiors have so far prioritised other work and they are ok to be on the version that still works for some months. TL:DR; If you need this fixed please open a new PR to address it which corrects the issues @crisbeto described above. That or beg that someone on the team takes it.

@crisbeto
Copy link
Member

crisbeto commented May 6, 2021

@swftvsn I can pick it up and make sure that the CI passes.

@chunghha
Copy link
Contributor

chunghha commented May 6, 2021

Opened #22634

Thanks @swftvsn for the fix.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants