-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/sort): fix undefined object access #22355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit fixes hard crash that results from accessing undefined object's property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but you have to run yarn approve-api sort
and commit the changed file.
Unfortunately I'm doing the edits from the GitHub web-interface, so it'll be some weeks (considering my workload atm) before I'm able to setup the whole dev environment for components. |
Instead of waiting, can we get this PR merged for a release as this is a production bug to who use current v11 version in their production? |
The same problem. |
I have no relation to angular and unfortunately I'm drowning in work. My superiors have so far prioritised other work and they are ok to be on the version that still works for some months. TL:DR; If you need this fixed please open a new PR to address it which corrects the issues @crisbeto described above. That or beg that someone on the team takes it. |
@swftvsn I can pick it up and make sure that the CI passes. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit fixes hard crash that results from accessing undefined object's property.