Skip to content

fix(input): character count hint for input #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

davidcraddock
Copy link

fix (input): Remove the property CharacterCounter on md-input. Add name
of local variable on md-input and add md-hint to fix counter binding of
md-input for the show hint lable with charater count example.

The property characterCounter does not exist on md-input and therefore
the character count was not being displayed for the show hint lable with
charater count example. Removing this and adding the name
#characterCountHintExampleInput along with the md-hint tag using the
name and the character count property fixes the issue.

fix (input): Remove the property CharacterCounter on md-input. Add name
of local variable on md-input and add md-hint to fix counter binding of
md-input for the show hint lable with charater count example.

The property characterCounter does not exist on md-input and therefore
the character count was not being displayed for the show hint lable with
charater count example. Removing this and adding the name
#characterCountHintExampleInput along with the md-hint tag using the
name and the character count property fixes the issue.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 15, 2016
@davidcraddock davidcraddock changed the title fix character count hint for input. fix(input) character count hint for input. Dec 15, 2016
@davidcraddock davidcraddock changed the title fix(input) character count hint for input. fix(input): character count hint for input. Dec 15, 2016
@davidcraddock davidcraddock changed the title fix(input): character count hint for input. fix(input): character count hint for input Dec 15, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 13, 2017
@dahaupt
Copy link

dahaupt commented Jan 13, 2017

@jelbourn Is this really merge ready? He should rebase first because of the deprecated md-input tag. Sorry if I am wrong about this.

@jelbourn
Copy link
Member

GitHub says merge base is clean. This demo will go away before too long, but in the meantime the change is still correct

@tinayuangao tinayuangao merged commit 6f94aa1 into angular:master Jan 13, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants