Skip to content

fix(positioning): fallback positions should work while scrolled #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2016
Merged

fix(positioning): fallback positions should work while scrolled #2193

merged 1 commit into from
Dec 14, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Dec 13, 2016 •
edited
Loading

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2016
@kara kara self-assigned this Dec 13, 2016
@kara kara added the in progress This issue is currently in progress label Dec 13, 2016
@kara kara added pr: needs review and removed in progress This issue is currently in progress labels Dec 14, 2016
@kara kara requested a review from jelbourn December 14, 2016 05:34
@kara kara assigned jelbourn and unassigned kara Dec 14, 2016
@kara
Copy link
Contributor Author

kara commented Dec 14, 2016 •
edited
Loading

Firefox and IE are unhappy. Looks like the scroll isn't happening in the tests.

Update: Fixed!

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2016
@jelbourn jelbourn merged commit 8df30db into angular:master Dec 14, 2016
@kara kara mentioned this pull request Dec 20, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kara @jelbourn @googlebot