-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Added required step into GETTING_STARTED.md file that is telling to S… #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ystem loader where Angular Material is located.
@@ -33,6 +33,34 @@ import { MaterialModule } from '@angular/material'; | |||
export class PizzaPartyAppModule { } | |||
``` | |||
|
|||
## Tell to System loader where Angular Material is located | |||
This is **required** step. You need to tell to system loader where angular material is located otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring SystemJS is only necessary if you're using SystemJS. If you're using Webpack (such as with angular-cli) or something like Browserify, RequireJS etc., this isn't necessary.
I'm okay with adding something on SystemJS since the angular quickstart uses it, but it should be further down (since not all projects use it). I'd put it as something like:
## Configuring SystemJS
If your project is using SystemJS for module loading, you will need to add `@angular/material` to the SystemJS configuration:
System.config({
// existing configuration options
map: {
...,
'@angular/material': 'npm:@angular/material/material.umd.js'
}
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn Thank you. I think that would be a good addition to getting started file, because there are lots of beginners who would use Systemjs with their Angular 2 application. That is also good description that you have added in code below. So let's go with it.
@amiral84 are you going to make the recommended changes in the PR? |
@jelbourn yes I will make it today as soon as possible. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@jelbourn now it is updated. :) |
@googlebot I signed it! |
CLAs look good, thanks! |
@@ -33,6 +33,20 @@ import { MaterialModule } from '@angular/material'; | |||
export class PizzaPartyAppModule { } | |||
``` | |||
|
|||
## Configuring SystemJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this section below ### Additional setup for
md-slide-toggleand
md-slider:
?
…toggle and md-slider section
LGTM, thanks! |
@jelbourn you're welcome :). Hope this will help many. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Added this required step where user have to tell to System loader where Angular Material2 is located.