Skip to content

fix(overlay-ref): check if parent node still exists before removing c… #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

janisr
Copy link
Contributor

@janisr janisr commented Nov 9, 2016

…hild

Getting the following exception in some scenarios, eg. multiple dialogs of the same type are open and closing them fast

TypeError: Cannot read property 'removeChild' of null
at HTMLDivElement. (overlay-ref.js:70)
at ZoneDelegate.invokeTask (zone.js:265)
at Object.onInvokeTask (ng_zone.js:227)
at ZoneDelegate.invokeTask (zone.js:264)
at Zone.runTask (zone.js:154)
at HTMLDivElement.ZoneTask.invoke (zone.js:335)

…hild

Getting the following exception in some scenarios, eg. multiple dialogs of the same type are open and closing them fast

 TypeError: Cannot read property 'removeChild' of null
    at HTMLDivElement.<anonymous> (overlay-ref.js:70)
    at ZoneDelegate.invokeTask (zone.js:265)
    at Object.onInvokeTask (ng_zone.js:227)
    at ZoneDelegate.invokeTask (zone.js:264)
    at Zone.runTask (zone.js:154)
    at HTMLDivElement.ZoneTask.invoke (zone.js:335)
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2016
@jelbourn
Copy link
Member

This will be fixed in #1716

@jelbourn jelbourn closed this Nov 10, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants