chore(dev-app): prevent multiple reloads per file change #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
R: @hansl |
hansl
approved these changes
Nov 7, 2016
| @@ -187,7 +187,7 @@ export function vendorTask() { | |||
|
|
|||
|
|
|||
| /** Create a task that serves the dist folder. */ | |||
| export function serverTask(liveReload = true, | |||
| export function serverTask(liveReload: boolean | { enable: boolean, filter: Function } = true, | |||
There was a problem hiding this comment.
Function => (filename: string, callback: (boolean) => void)
crisbeto
force-pushed
the
1681/devapp-reloads
branch
from
311d2bd to
f7d400b
Compare
|
Updated @hansl. |
hansl
suggested changes
Nov 8, 2016
| export type livereloadOptions = boolean | { | ||
| enable: boolean, | ||
| filter: (filename: string, callback: (isAllowed: boolean) => void) => void; | ||
| } |
There was a problem hiding this comment.
Are you referring to the comma after enable or adding a semicolon after the export? If it's the latter, none of the other exports use a semicolon.
| export function serverTask(liveReload = true, | ||
| streamCallback: (stream: NodeJS.ReadWriteStream) => void = null) { | ||
| export function serverTask(liveReload: livereloadOptions = true, | ||
| streamCallback: (stream: NodeJS.ReadWriteStream) => void = null) { |
There was a problem hiding this comment.
Left align with liveReload above.
Prevents the local dev app from reloading 5-6 times whenever a file changes. Adds a filter that only watches for the bundle (which also contains all of the CSS and HTML), theme changes and changes to the demo apps. Fixes angular#1681.
crisbeto
force-pushed
the
1681/devapp-reloads
branch
from
f7d400b to
5227bc3
Compare
hansl
added
action: merge
rolandjitsu
pushed a commit
to rolandjitsu/material2
that referenced
this pull request
Nov 10, 2016
Prevents the local dev app from reloading 5-6 times whenever a file changes. Adds a filter that only watches for the bundle (which also contains all of the CSS and HTML), theme changes and changes to the demo apps. Fixes angular#1681.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the local dev app from reloading 5-6 times whenever a file changes. Adds a filter that only watches for the bundle (which also contains all of the CSS and HTML), theme changes and changes to the demo apps.
Fixes #1681.