docs(chips): chips autocomplete demo separator key codes not working correctly #17558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly In angular#12971 `addOnBlur` was added to the chips autocomplete example, however it ended up breaking pressing the separator keys while the autocomplete is open. These changes remove the `addOnBlur` since having an autocomplete and adding chips on blur inherrently doesn't work together, because clicking on the autocomplete will blur the input. We could technically hack around it with a timeout, but that'll make the demo more confusing. Fixes angular#17448.
crisbeto
added
P3
googlebot
added
the
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12971
addOnBlurwas added to the chips autocomplete example, however it ended up breaking pressing the separator keys while the autocomplete is open. These changes remove theaddOnBlursince having an autocomplete and adding chips on blur inherrently doesn't work together, because clicking on the autocomplete will blur the input. We could technically hack around it with a timeout, but that'll make the demo more confusing.Fixes #17448.