build: update jasmine types dependency #16834
Conversation
devversion
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/update-jasmine-types-dep
branch
from
e310a43 to
20e0712
Compare
Updates the jasmine types to the latest version. Unfortunately the update didn't bring in the types for the `jasmine.Env.configure` method, but it's still a good thing to update as it helps tsetse catch more incomplete test expectations.
devversion
force-pushed
the
build/update-jasmine-types-dep
branch
from
20e0712 to
1cbc485
Compare
devversion
added
pr: merge safe
target: patch
| @@ -45,7 +45,7 @@ export function createFakeYtNamespace(): FakeYtNamespace { | |||
|
|
|||
| for (const [event, callback] of playerSpy.addEventListener.calls.allArgs()) { | |||
| if (event === name) { | |||
| callback(arg); | |||
| callback(arg as YT.PlayerEvent); | |||
There was a problem hiding this comment.
Note: I tried fixing this by improving type-safety in this method overall, but it looks like this is not possible as the passed arg needs to be less tightened. Also the as any cast above can't be replaced with YT.PlayerEvent.
This test utility seems to need a general cleanup for type safety, but out of scope for this PR. The type update just caused a compilation failure as the addEventListener callback type is now inferred properly and expects YT.PlayerEvent.
jelbourn
added
pr: lgtm
action: merge
Updates the jasmine types to the latest version. Unfortunately the update didn't bring in the types for the `jasmine.Env.configure` method, but it's still a good thing to update as it helps tsetse catch more incomplete test expectations. (cherry picked from commit 7c40679)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the jasmine types to the latest version. Unfortunately the update
didn't bring in the types for the
jasmine.Env.configuremethod for #16833,but it's still a good thing to update as it helps tsetse catch more incomplete
test expectations.