Skip to content

feat(core): directive to add extra classes to components for m1 compat #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2016

Conversation

jelbourn
Copy link
Member

See #1479

I don't like the name "Compatibility" but I don't have any better ideas.

I had originally been thinking we'd have to add the class in the constructor for each individual components, but this approach is much cleaner.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2016
@jelbourn jelbourn added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Oct 13, 2016
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyleCompatibilityModule?

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2016
@jelbourn
Copy link
Member Author

Good to merge if CI is green

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Oct 14, 2016
@jelbourn
Copy link
Member Author

Nope, problem with md-menu (which already has an md-menu class).

@jelbourn jelbourn merged commit ec1e180 into angular:master Oct 19, 2016
@jelbourn jelbourn deleted the m1-css-compat branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants