-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(theming): add initial guide for theming. #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a theme consists of: | ||
* A primary palette: colors most widely used across all screens and components. | ||
* An accent palette: colors used for the floating action button and interactive elements. | ||
* A "warn" palette: colors used to convey error state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious - why is this the only one with quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Primary palette" and "accent palette" both sounded natural, while "warn palette" seemed weird. Removed.
add a new entry to the `"styles"` list in `angular-cli.json` pointing to the theme | ||
file (e.g., `unicorn-app-theme.scss`). | ||
|
||
If you're not using the Angular CLI, you can use any existing sass tooling to build the file (such |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sass -> Sass (for consistency)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
``` | ||
|
||
### Future work | ||
* When the "all" package is release, there will be a mixin that captures all of the component's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release -> released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
<link href="node_modules/@angular2-material/core/theming/prebuilt/indigo-pink.css" rel="stylesheet"> | ||
``` | ||
|
||
You can also concatenate the file with the rest of your application's css. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be handy to have a list of the existing pre-built themes here as bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add that once we have a full complement of prebuilts (only three right now)
Just gotta say, looking at this PR - this is awesome! Really like the use of mixins for encapsulating the theming logic. Will be poaching those ideas for other projects, @jelbourn . |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @kara
For merging after #1239