Skip to content

refactor(all): add index.ts, and build using es2015 and UMD bundles. #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 1, 2016

Similar to angular/angular.

As well:

  • moved every @angular2-material/ZZZ/ZZZ to use the index
  • moved every deep import from @angular2-material/core to the root of the package
  • created an new tsconfig for spec files (since we won't compile spec files with umd because simpler)
  • system config in lib has been renamed to system-config-spec because it's a spec-only file (one could say it's "spec-specific")
  • now clean before running unittests, because it's safer.

The UMD bundles are rolled up to @angular2-material/XXX/XXX.umd.js while the es2015 are @angular2-material/XXX/index.js.

Packages have been updated.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2016
@kara kara added pr: needs review blocked This issue is blocked by some external factor, such as a prerequisite PR and removed pr: needs review labels Sep 1, 2016
@kara kara added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Sep 2, 2016
@kara kara merged commit 818290b into angular:master Sep 2, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants