Skip to content

chore(release): update versions for alpha.8 #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2016
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented Sep 1, 2016

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2016
@kara kara added pr: needs review blocked This issue is blocked by some external factor, such as a prerequisite PR and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 1, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2016
@fxck
Copy link
Contributor

fxck commented Sep 2, 2016

Wouldn't the need of forRoot() on some components be worth mentioning?

As well as that module.id is back, which is likely gonna cause uri.match error for webpack users?

@kara
Copy link
Contributor Author

kara commented Sep 2, 2016

@fxck Modules IDs are stripped during the release build process. We need to keep them in the repo for internal syncing reasons, but they're not part of the NPM package. So effectively nothing is changing there.

Re other changes for the log, we are still updating it as changes come in.

@kara kara removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 2, 2016

### BREAKING CHANGES

* all: we've updated our packaging to match angular/angular's packaging. If you're using System.js in your project, you will probably want to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.js > SystemJS

@jelbourn
Copy link
Member

jelbourn commented Sep 2, 2016

LGTM aside from those two minor comments

@kara kara force-pushed the alpha8 branch 2 times, most recently from 80cd785 to 24afcd1 Compare September 2, 2016 19:19
@kara kara added the action: merge The PR is ready for merge by the caretaker label Sep 2, 2016
@kara kara merged commit 9a991cc into angular:master Sep 2, 2016
@codespicelabs
Copy link

With webpack alpha.8 (https://www.npmjs.com/~angular2-material) fails to this:

WARNING in ./~/@angular2-material/button-toggle/button-toggle.js
15:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./~/@angular2-material/button/button.js
17:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./~/@angular2-material/checkbox/checkbox.js
12:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

... and for all the others MD2 components

@kara
Copy link
Contributor Author

kara commented Sep 2, 2016

@codespicelabs see #1167 and #1168

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants